Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #385: Increase test coverage for Lwt_result #440

Merged
merged 5 commits into from
Jul 10, 2017
Merged

Issue #385: Increase test coverage for Lwt_result #440

merged 5 commits into from
Jul 10, 2017

Conversation

jsthomas
Copy link
Contributor

This change adds tests to bring coverage for Lwt_result up to 100%.

@aantron
Copy link
Collaborator

aantron commented Jul 10, 2017

Don't worry about the failed CI builds. We will remove the working-coverage branch after this PR, since #438 makes it unnecessary for the Lwt core, and we can just use master. The fatal warning messing up CI is fixed in master by 4557ea1.

@aantron aantron merged commit c980f82 into ocsigen:working-coverage Jul 10, 2017
aantron pushed a commit that referenced this pull request Jul 10, 2017
@jsthomas @aantron
Increase test coverage for Lwt_result (#440)
99f556b 
Cherry-picked into master.
@aantron
Copy link
Collaborator

aantron commented Jul 10, 2017

Thanks! I cherry-picked this into master as 99f556b. Also want to add a link to #385 (and from it).

@jsthomas jsthomas deleted the test_lwt_result branch July 11, 2017 02:28
@aantron aantron mentioned this pull request Jul 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsthomas @aantron