Add Lwt_mvar.(take_available, is_empty) #459
Conversation
Factoring out next_writer as common (internal) functionality.
Use Lwt_mvar.take_available as a base to avoid a bit of duplicate logic.
|
I've split the PR into a handful of commits to show the steps taken. If you're happy with the implementation feel free to merge as-is or squash on merge. |
| let x = Lwt_mvar.create 0 in | ||
| let y = Lwt_mvar.take_available x in | ||
| Lwt.return (y = Some 0) | ||
| ); |
There was a problem hiding this comment.
There should be another test to check that after take_available has been called, the mvar is empty. Something along the lines of:
test "take_available (twice)"
(fun () ->
let m = Lwt_mvar.create 0 in
let (_: int option) = Lwt_mvar.take_available m in
let t = Let_mvar.take_available m in
Lwt.return (t = None)
);
There was a problem hiding this comment.
Good suggestion, thanks! Added in 7799c15
|
It looks good. Thanks @hcarty for the PR, @raphael-proust for the insightful review, and @jsthomas for writing the tests for existing I restarted the stuck AppVeyor build. Will merge once that is finished. |
|
Yes, big thanks to @jsthomas! Your work made adding these tests very very simple. |
Closes #443