[5.0.0] Lwt.pick, etc raise Invalid_argument on empty list #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thank you! This resolves #557, so I'll close that issue. As described in #557, the PR will have to remain open (for at least three months), but I/others working on Lwt will merge it at the right time :) Optional: it seems the email address in the commit metadata is not one of the ones associated with your GitHub account, so that's why GitHub is unable to link the commits to your user. Perhaps you're already aware of this, but if not, you may want to amend these commits to change the email address, or resolve this otherwise. cc @hcarty |
|
Thank you @timreinke! |
aantron
changed the title
|
You're very welcome, thanks for letting me take a crack at it. Thanks for pointing out the email issue @aantron - whoops. I went ahead and fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #557, this PR adjusts the behavior of
Lwt.pick,Lwt.choose,Lwt.npick,Lwt.nchoose, andLwt.nchoose_splitraiseInvalid_argumentwhen passed an invalid list. The test and docs are updated to reflect the new behavior.