unix_termios_conversion.c: Support for higher baud rates. #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes Lwt_unix.tcsetattr/tcgetattr compatible with the corresponding Unix library functions at higher baudrates. See ocaml/ocaml#6781 for details.
|
Thanks. Disregard the AppVeyor failure. Hopefully this will be fixed soon. If not, we will move the build to allowed failures. |
|
Looks good, will merge after Travis finishes. It looks like the commit that merged this support into the compiler was actually merged for 4.03: ocaml/ocaml@860c670. However, Lwt support doesn't look like it depends on the compiler having the corresponding code, so it should work in 4.02 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Lwt_unix.tcsetattr/tcgetattr functions compatible with the corresponding Unix library functions at higher baudrates.
These extra baudrates are in OCaml's standard library since v.4.02 (see ocaml/ocaml#6781 for details). Code is taken directly from there.