Add svg fill-rule attribute #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks ! Since it has a new type and a new ppx rule, please add a least a small test there, and then I'll merge. |
|
Nice! Since there are only two valid inputs to |
|
Thanks @dedbox ! :) |
Drup
added a commit
to Drup/opam-repository
that referenced
this pull request
Sep 29, 2023
CHANGES: * Update for OCaml 5.0 and drop support for OCaml 4.2.0 (ocsigen/tyxml#312 by @rr0gi) * Add additional variants to `linktype` for the `rel` attribute (Leon @LogicalOverflow Vack) * Expand options for `autocomplete` attribute on `<input>` elements (ocsigen/tyxml#302 by Aron @aronerben Erben) * Fix the SVG element `<animate>` (by the way, deprecate `animation` et al. in favor of `animate` et al.) (ocsigen/tyxml#306 by Idir @ilankri Lankri) * Add support for `dialog` element and `onclose` attribute (ocsigen/tyxml#301 by Julien Sagot) * Add an escape hatch for emitting attributes with non-standard names in jsx or ppx code (a leading `_` character on attribute name) (ocsigen/tyxml#295 Chas @cemerick Emerick) * Add support for `type` attribute on `<script>` elements (ocsigen/tyxml#293 by Ulrik @ulrikstrid Strid and Chas @cemerick Emerick) * Add svg `fill-rule` attribute (ocsigen/tyxml#294 by Eric @dedbox Griffis)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * Update for OCaml 5.0 and drop support for OCaml 4.2.0 (ocsigen/tyxml#312 by @rr0gi) * Add additional variants to `linktype` for the `rel` attribute (Leon @LogicalOverflow Vack) * Expand options for `autocomplete` attribute on `<input>` elements (ocsigen/tyxml#302 by Aron @aronerben Erben) * Fix the SVG element `<animate>` (by the way, deprecate `animation` et al. in favor of `animate` et al.) (ocsigen/tyxml#306 by Idir @ilankri Lankri) * Add support for `dialog` element and `onclose` attribute (ocsigen/tyxml#301 by Julien Sagot) * Add an escape hatch for emitting attributes with non-standard names in jsx or ppx code (a leading `_` character on attribute name) (ocsigen/tyxml#295 Chas @cemerick Emerick) * Add support for `type` attribute on `<script>` elements (ocsigen/tyxml#293 by Ulrik @ulrikstrid Strid and Chas @cemerick Emerick) * Add svg `fill-rule` attribute (ocsigen/tyxml#294 by Eric @dedbox Griffis)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed that there is a
`Fill_ruleconstructor inSvg_types.presentation_attr, but I could not find an attribute function that uses it. So, this PR adds ana_fill_ruleattribute function that accepts`Nonzeroor`Evenodd.See https://www.w3.org/TR/SVG11/painting.html#FillRuleProperty for details on the fill-rule attribute.
I believe this branch is at least mostly ready for review. Since this is my first contribution, I'm not entirely sure. I have succeeded in using
a_fill_rulefrom my local fork in another project, and the existing unit tests are passing, but I have not added any new unit tests.