Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort keys deeply #261

Merged
merged 4 commits into from
Jan 30, 2025
Merged

refactor: sort keys deeply #261

merged 4 commits into from
Jan 30, 2025

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jan 30, 2025

in preparation of fixing the current update workflow to unblock actions/create-github-app-token#168

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Is there supposed to be code here? So the order doesn't just change all the time

@gr2m
Copy link
Contributor Author

gr2m commented Jan 30, 2025

Is there supposed to be code here? So the order doesn't just change all the time

good point

@gr2m
Copy link
Contributor Author

gr2m commented Jan 30, 2025

done 👍🏼

@gr2m gr2m merged commit a998087 into main Jan 30, 2025
4 checks passed
@gr2m gr2m deleted the resort-keys branch January 30, 2025 23:49
@wolfy1339
Copy link
Member

Btw, I did have a stab at updating in #247

It's what I could figure out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants