Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in test.yml #222

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Fix typo in test.yml #222

merged 6 commits into from
Jun 23, 2023

Conversation

kfcampbell
Copy link
Member

@kfcampbell kfcampbell commented Jun 23, 2023

@nickfloyd and I have spent some time pairing on #219 today! It turns out the cause was a typo in the Actions step name when retrieving (successful) stored GraphQL query results.

I also posit that another issue was the missing newline before attempting to run [[ ${COMMITS_COUNT} -eq 6 ]]. Without the newline, Actions tries to parse the entire block as one single command.

@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 23, 2023
@kfcampbell kfcampbell changed the title Update test.yml Fix typo in test.yml Jun 23, 2023
@kfcampbell kfcampbell marked this pull request as ready for review June 23, 2023 21:50
@kfcampbell kfcampbell requested a review from nickfloyd June 23, 2023 21:50
@kfcampbell kfcampbell merged commit 7340e30 into main Jun 23, 2023
@kfcampbell kfcampbell deleted the variables-experiment branch June 23, 2023 21:53
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 2.2.25 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants