[BUG]: @octokit/[email protected] incompatible with @octokit/[email protected]

[bcoe]

What happened?

When upgrading to the latest version of @octokit/types, typescript throws compilation errors.

Versions

@octokit/[email protected] incompatible with @octokit/[email protected]

Relevant log output

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:848:33 - error TS2339: Property 'PUT /organizations/{org}/codespaces/secrets/{secret_name}/repositories/{repository_id}' does not exist on type 'Endpoints'.

848             response: Endpoints["PUT /organizations/{org}/codespaces/secrets/{secret_name}/repositories/{repository_id}"]["response"];
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:859:60 - error TS2339: Property 'PUT /organizations/{org}/codespaces/secrets/{secret_name}' does not exist on type 'Endpoints'.

859             parameters: RequestParameters & Omit<Endpoints["PUT /organizations/{org}/codespaces/secrets/{secret_name}"]["parameters"], "baseUrl" | "headers" | "mediaType">;
                             

Code of Conduct

• I agree to follow this project's Code of Conduct

[wolfy1339]

This is normal, as the packages all depend on each other and need to be kept in sync

A new release of this package needs to be released with the update to @octokit/types

[benjdlambert]

@wolfy1339 have you considered using semver for releases to the types? It looks like a lot of things were removed in the latest changes which obviously have impacts downstream for packages even under the @octokit org. New installs of these packages are currently broken and fail tsc when skipLibCheck=false

edit:
It looks like you do follow semver, but the last release that went out removed a lot of things from the public facing API and therefore is a breaking change, and it wasn't released as such.
https://github.com/octokit/types.ts/pull/499/files#diff-6e34f3ccc1fd41b44cec74317606475053c89f3ffe0133356443861f5e7f1150L1413-L1447

[wolfy1339]

That can be arranged. A major version bump can be done. Sorry for the troubles!

However, even with a feature release, the different packages still need to be kept in sync, as they all cascade off one another

[benjdlambert]

@wolfy1339 thanks for the reply! Yeah, I think in order to fix it that 8.2.0 release will either need to be unpublished, or 8.2.1 to be released with the previous generated stuff before the PR, and then a followup release of 9.0.0 with the contents of the PR.

However, even with a feature release, the different packages still need to be kept in sync, as they all cascade off one another

Yep totally get that for new features etc!

[wolfy1339]

I've started submitting PRs to remedy the situation
Starting off with: octokit/types.ts#501

[bcoe]

Thank you @wolfy1339