-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: many unrelease endpoint updates #497
Conversation
The PR description says "avoid breaking changes at all costs", and there is what appears to be several breaking changes for removed endpoints in this PR. I'm unsure what the correct path forward is here. |
As a general rule of thumb, a breaking change in types does not always necessarily mean a breaking change in the consumer package. I'm not entirely well versed on this package and how it works. I would think that a breaking change would be warranted in this case This should probably be documented somewhere
|
The version of |
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
If there are any new endpoints, then the code changes will likely required an update of
@octokit/types
. It should have received a pull request as well, merge & release it first. The@octokit/types
should be updated automatically shortly after in this pull request.Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.
In general
docs
prefixfix(typescript)
prefixfix
if a problem was resolved,feat
if new endpoints / parameters were added, andfeat(deprecation)
if a method was deprecated.