refactor: failover from native fetch to node-fetch

[baoshan]

fetch API has landed in Node.js 18 (and is available in modern browsers, Deno, Clodflare, etc). Failover from native fetch to node-fetch makes us confident that there will be no issues when node-fetch is removed (say in 2046).

A new pattern of testing is made possible: instead of creating new instances of Octokit in test cases (with different fetch mocks), I can simply stub globalThis.fetch in test cases using a same instance of Octokit (imported from non-test code).

In some rare cases, this PR may break existing code. But generally I think it is safe.

[wolfy1339]

Would this work as a fix for #456?

[baoshan]

No.

To be absolutely friendly to bundlers that support importing npm packages, we need to remove the node-fetch dependency from @octokit/request; users need to pass a fetch if their runtime has no native fetch.

I think OP is using Netlify’s edge function, which is Deno Deploy rebranded. We can import https://esm.sh/@octokit/core or http://esm.sh/@octokit/request instead. node-fetch is replaced by node-fetch-native there.

[wolfy1339]

Thanks for the clarifications

[github-actions]

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀