Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace "@sinonjs/fake-timers" with Jest timers #217

Closed
gr2m opened this issue Aug 24, 2020 · 1 comment · Fixed by #238
Closed

replace "@sinonjs/fake-timers" with Jest timers #217

gr2m opened this issue Aug 24, 2020 · 1 comment · Fixed by #238
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@gr2m
Copy link
Contributor

gr2m commented Aug 24, 2020

follow up for #188

I've introduced @sinonjs/fake-timers in #190, before the migration to Jest. As Jest has its own solution for mocking time, we should use that instead of @sinonjs/fake-timers
@gr2m gr2m added the Status: Up for grabs Issues that are ready to be worked on by anyone label Aug 24, 2020
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Aug 24, 2020
@oscard0m oscard0m mentioned this issue Aug 25, 2020
Merged
@gr2m gr2m closed this as completed in #238 Aug 25, 2020
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 7.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(server-test): refactor mock setTimeout using Jest's utility
2 participants
@gr2m @wolfy1339