Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server-test): refactor mock setTimeout using Jest's utility #238

Merged
merged 2 commits into from
Aug 25, 2020
Merged

test(server-test): refactor mock setTimeout using Jest's utility #238

merged 2 commits into from
Aug 25, 2020

Conversation

oscard0m
Copy link
Member

📝 Summary

Use Jest's fake timeout utility instead of sinonjs/fake-timer one

⛱ Motivation and Context

Fix #217

@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Aug 25, 2020
@oscard0m oscard0m requested review from wolfy1339 and gr2m and removed request for wolfy1339 August 25, 2020 20:32
gr2m
gr2m approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@gr2m gr2m merged commit 179fdad into octokit:master Aug 25, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace "@sinonjs/fake-timers" with Jest timers
2 participants
@oscard0m @gr2m