Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add onAny and onError functions #324

Merged
merged 9 commits into from
Oct 17, 2020
Merged

feat: Add onAny and onError functions #324

merged 9 commits into from
Oct 17, 2020

Conversation

wolfy1339
Copy link
Member

Fixes #304

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Oct 13, 2020
oscard0m
oscard0m previously approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@oscard0m oscard0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wolfy1339
wolfy1339 commented Oct 13, 2020
View reviewed changes
src/event-handler/index.ts Outdated Show resolved Hide resolved
@wolfy1339
Copy link
Member Author

@gr2m I can't seem to push to the branch anymore

@gr2m
Copy link
Contributor

gr2m commented Oct 14, 2020

@wolfy1339 sorry for that. I've invited you and @dominguezcelada to the new @octokit/js-community team, you should have write access to all JS repositories now :)

@wolfy1339 wolfy1339 requested review from oscard0m and gr2m October 14, 2020 22:38
@wolfy1339 wolfy1339 marked this pull request as ready for review October 14, 2020 22:40
@wolfy1339 wolfy1339 force-pushed the any-error-events-deprecate branch from e4396e4 to 8d75648 Compare October 14, 2020 23:52
gr2m
gr2m approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍🏼

@gr2m gr2m merged commit 3117844 into master Oct 17, 2020
@gr2m gr2m deleted the any-error-events-deprecate branch October 17, 2020 04:09
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m changed the title feat: Add onAny and onEvent functions feat: Add onAny and onError functions Oct 30, 2020
@gr2m gr2m mentioned this pull request Oct 30, 2020
Closed
@billyvg billyvg mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscard0m oscard0m oscard0m approved these changes

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create .onAny and .onError methods, deprecate "*" and "error" events
3 participants
@wolfy1339 @gr2m @oscard0m