Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymorphic custom property values (fixes deserialization bug) #521

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

colbylwilliams
Copy link
Contributor

Resolves #520


Before the change?

  • Custom Property and Custom Property Value schemas added new value_types and updated the default_value and value properties to allow for null, string, or array. This breaks deserialization of payloads with Custom Property or Custom Property Values. See issue for more details.

After the change?

  • Added multi_select, and true_false custom property value types
  • Custom Property definition default_value may be null, string, or array of strings
  • Custom Property value property may be null, string, or array of strings
  • Updated Repository.CustomProperties to be IDictionary<string, object> to support polymorphic values of either string or array

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@colbylwilliams
Copy link
Contributor Author

cc: @JamieMagee

@JamieMagee JamieMagee enabled auto-merge (squash) June 27, 2024 15:56
@JamieMagee JamieMagee merged commit 936ebd8 into octokit:main Jun 27, 2024
7 checks passed
@colbylwilliams colbylwilliams deleted the custom-properties-v3 branch June 27, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: New custom property polymorphic values break deserialization
2 participants