fix: add missing property category.node_id to discussion and `dis…

…cussion_comment` (#960)
octokit · Oct 3, 2024 · 049c104 · 049c104
1 parent 524ed0d
commit 049c104
Show file tree

Hide file tree

Showing 22 changed files with 85 additions and 74 deletions.
diff --git a/payload-examples/api.github.com/discussion/answered.payload.json b/payload-examples/api.github.com/discussion/answered.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809315,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 141753607,
       "emoji": ":pray:",
       "name": "Q&A",

diff --git a/payload-examples/api.github.com/discussion/category_changed.payload.json b/payload-examples/api.github.com/discussion/category_changed.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809317,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 141753607,
       "emoji": ":raised_hands:",
       "name": "Show and tell",
@@ -54,6 +55,7 @@
     "category": {
       "from": {
         "id": 32809314,
+        "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE",
         "repository_id": 141753607,
         "emoji": ":speech_balloon:",
         "name": "General",

diff --git a/payload-examples/api.github.com/discussion/created.payload.json b/payload-examples/api.github.com/discussion/created.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/edited.payload.json b/payload-examples/api.github.com/discussion/edited.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/edited.with-reactions.payload.json b/payload-examples/api.github.com/discussion/edited.with-reactions.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/labeled.payload.json b/payload-examples/api.github.com/discussion/labeled.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/labeled.with-reactions.payload.json b/payload-examples/api.github.com/discussion/labeled.with-reactions.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/locked.payload.json b/payload-examples/api.github.com/discussion/locked.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 141753607,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/locked.with-reactions.payload.json b/payload-examples/api.github.com/discussion/locked.with-reactions.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 141753607,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/pinned.payload.json b/payload-examples/api.github.com/discussion/pinned.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/transferred.payload.json b/payload-examples/api.github.com/discussion/transferred.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809315,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 141753607,
       "emoji": ":pray:",
       "name": "Q&A",
@@ -55,6 +56,7 @@
       "repository_url": "https://api.github.com/repos/Codertocat/friendly-octo-succotash",
       "category": {
         "id": 32809824,
+        "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5ODI",
         "repository_id": 353173080,
         "emoji": ":pray:",
         "name": "Q&A",

diff --git a/payload-examples/api.github.com/discussion/unanswered.payload.json b/payload-examples/api.github.com/discussion/unanswered.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809315,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 141753607,
       "emoji": ":pray:",
       "name": "Q&A",

diff --git a/payload-examples/api.github.com/discussion/unlabeled.payload.json b/payload-examples/api.github.com/discussion/unlabeled.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion/unlocked.payload.json b/payload-examples/api.github.com/discussion/unlocked.payload.json
@@ -4,6 +4,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
       "repository_id": 141753607,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion_comment/created.payload.json b/payload-examples/api.github.com/discussion_comment/created.payload.json
@@ -49,6 +49,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEwOkkpc4F1c3Npg24zMjk5NjE0",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion_comment/deleted.payload.json b/payload-examples/api.github.com/discussion_comment/deleted.payload.json
@@ -49,6 +49,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEwOkkpc4F1c3Npg24zMjk5NjE0",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/discussion_comment/edited.payload.json b/payload-examples/api.github.com/discussion_comment/edited.payload.json
@@ -50,6 +50,7 @@
     "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
     "category": {
       "id": 32809314,
+      "node_id": "MDEwOkkpc4F1c3Npg24zMjk5NjE0",
       "repository_id": 186853002,
       "emoji": ":speech_balloon:",
       "name": "General",

diff --git a/payload-examples/api.github.com/index.json b/payload-examples/api.github.com/index.json
@@ -12116,6 +12116,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809315,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 141753607,
             "emoji": ":pray:",
             "name": "Q&A",
@@ -12344,6 +12345,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809317,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 141753607,
             "emoji": ":raised_hands:",
             "name": "Show and tell",
@@ -12394,6 +12396,7 @@
           "category": {
             "from": {
               "id": 32809314,
+              "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE",
               "repository_id": 141753607,
               "emoji": ":speech_balloon:",
               "name": "General",
@@ -12535,6 +12538,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -12711,6 +12715,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -12888,6 +12893,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -13077,6 +13083,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -13262,6 +13269,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -13459,6 +13467,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 141753607,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -13635,6 +13644,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 141753607,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -13823,6 +13833,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -13999,6 +14010,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809315,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 141753607,
             "emoji": ":pray:",
             "name": "Q&A",
@@ -14050,6 +14062,7 @@
             "repository_url": "https://api.github.com/repos/Codertocat/friendly-octo-succotash",
             "category": {
               "id": 32809824,
+              "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5ODI",
               "repository_id": 353173080,
               "emoji": ":pray:",
               "name": "Q&A",
@@ -14326,6 +14339,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809315,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 141753607,
             "emoji": ":pray:",
             "name": "Q&A",
@@ -14535,6 +14549,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -14720,6 +14735,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEyOkRpc2N1c3Npb25DYWNoZTMyODA5MzE1",
             "repository_id": 141753607,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -15185,6 +15201,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEwOkkpc4F1c3Npg24zMjk5NjE0",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -15406,6 +15423,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEwOkkpc4F1c3Npg24zMjk5NjE0",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",
@@ -15628,6 +15646,7 @@
           "repository_url": "https://api.github.com/repos/Codertocat/Hello-World",
           "category": {
             "id": 32809314,
+            "node_id": "MDEwOkkpc4F1c3Npg24zMjk5NjE0",
             "repository_id": 186853002,
             "emoji": ":speech_balloon:",
             "name": "General",

diff --git a/payload-schemas/api.github.com/common/discussion-category.schema.json b/payload-schemas/api.github.com/common/discussion-category.schema.json
@@ -0,0 +1,31 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema",
+  "$id": "common/discussion-category.schema.json",
+  "type": "object",
+  "required": [
+    "id",
+    "node_id",
+    "repository_id",
+    "emoji",
+    "name",
+    "description",
+    "created_at",
+    "updated_at",
+    "slug",
+    "is_answerable"
+  ],
+  "properties": {
+    "id": { "type": "integer" },
+    "node_id": { "type": "string" },
+    "repository_id": { "type": "integer" },
+    "emoji": { "type": "string" },
+    "name": { "type": "string" },
+    "description": { "type": "string" },
+    "created_at": { "type": "string", "format": "date-time" },
+    "updated_at": { "type": "string", "format": "date-time" },
+    "slug": { "type": "string" },
+    "is_answerable": { "type": "boolean" }
+  },
+  "additionalProperties": false,
+  "title": "Discussion Category"
+}
diff --git a/payload-schemas/api.github.com/common/discussion.schema.json b/payload-schemas/api.github.com/common/discussion.schema.json
@@ -25,32 +25,7 @@
   "type": "object",
   "properties": {
     "repository_url": { "type": "string" },
-    "category": {
-      "type": "object",
-      "required": [
-        "id",
-        "repository_id",
-        "emoji",
-        "name",
-        "description",
-        "created_at",
-        "updated_at",
-        "slug",
-        "is_answerable"
-      ],
-      "properties": {
-        "id": { "type": "integer" },
-        "repository_id": { "type": "integer" },
-        "emoji": { "type": "string" },
-        "name": { "type": "string" },
-        "description": { "type": "string" },
-        "created_at": { "type": "string", "format": "date-time" },
-        "updated_at": { "type": "string", "format": "date-time" },
-        "slug": { "type": "string" },
-        "is_answerable": { "type": "boolean" }
-      },
-      "additionalProperties": false
-    },
+    "category": { "$ref": "discussion-category.schema.json" },
     "answer_html_url": { "type": ["string", "null"] },
     "answer_chosen_at": {
       "oneOf": [{ "type": "string", "format": "date-time" }, { "type": "null" }]