Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypeCall work with TVMScript #18

Merged
merged 6 commits into from
Nov 29, 2021
Merged

Make TypeCall work with TVMScript #18

merged 6 commits into from
Nov 29, 2021

Conversation

shingjan
Copy link
Member

This PR intends to add necessary code change to synr in order to support TVM#9492

@shingjan shingjan requested review from tkonolige and altanh November 22, 2021 08:28
@shingjan shingjan marked this pull request as ready for review November 22, 2021 08:31
@tkonolige
Copy link
Contributor

@shingjan Can you add a test

@shingjan shingjan changed the title [WIP] Make TypeCall work with TVMScript Make TypeCall work with TVMScript Nov 23, 2021
@shingjan
Copy link
Member Author

@tkonolige test is added.

tkonolige
tkonolige reviewed Nov 23, 2021
View reviewed changes
synr/ast.py Show resolved Hide resolved
@shingjan shingjan requested a review from tkonolige November 24, 2021 00:07
@shingjan
Copy link
Member Author

shingjan commented Nov 24, 2021 •
edited
Loading

@tkonolige It seems to me that if we do Dict[Id, Type], this line won't work while creating the keyword_params of TypeCall. There isn't a function to transform expr to id. Do you think there is any workaround on this?

@tkonolige
Copy link
Contributor

Ah, sure we can change it in a later PR.

@shingjan
Copy link
Member Author

@tkonolige have the change reversed. Should be good to merge after CI passes

@tkonolige tkonolige merged commit 4745e5d into octoml:master Nov 29, 2021
@tkonolige
Copy link
Contributor

Thanks @shingjan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altanh altanh Awaiting requested review from altanh

@tkonolige tkonolige Awaiting requested review from tkonolige

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shingjan @tkonolige