-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for "dune external-lib-deps" command #46
Conversation
The new version of dune (from 3.0.0) removed "dune external-lib-deps" and this is a patch that work with a patch of dune from "https://github.com/moyodiallo/dune/tree/opam-dune-lint". There's already a PR(ocaml/dune#6045) in dune about this patch, but not guarantee to be merged. The command may change also.
The library dune-lang is not exposed anymore. It started at 3.0.0 .
In this stage, opam-dune-lint can only works with this dune PR "ocaml/dune#6839". Not ready yet, works is needed at this stage.
At the stage This particular example is left for now, because (executable{s}
(name{s} prog)
(libraries a b))
(install
(section bin)
(package pkg)
(files prog.exe))
|
This could use more tests for the dune-file parsing since we no longer use dune's parser for files. |
The command 'dune describe external-lib-deps' is used to print out external-libs and does not print an internal lib.
90f05c4
to
4113435
Compare
I rewrite the PR, there was some error that I made. At this stage there's 2 things left:
|
4113435
to
7b2bb28
Compare
At this stage, it could be tested with this branch https://github.com/moyodiallo/dune/tree/opam-dune-lint-testing. |
7b2bb28
to
333a495
Compare
* The command "dune describe package-entries" is used to know if a private executable is going to be installed. * Resolve all the internal dependencies.
a29fd86
to
c339d01
Compare
This issue #28 is now fixed in the current PR. |
78bc65f
to
1e642ae
Compare
1e642ae
to
02ae26b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions on coding style.
396718b
to
9f37c7e
Compare
9f37c7e
to
34fb3ee
Compare
34fb3ee
to
6b24915
Compare
66acfa5
to
54a27d8
Compare
When will this be released? |
We are testing it on https://ocaml.ci.dev/ via |
CHANGES: - Add support for dune 3.0 , the command `dune external-lib-deps` was removed from dune. Now, the `opam-dune-lint` command works without `dune build`. (@moyodiallo ocurrent/opam-dune-lint#46).
CHANGES: - Add support for dune 3.0 , the command `dune external-lib-deps` was removed from dune. Now, the `opam-dune-lint` command works without `dune build`. (@moyodiallo ocurrent/opam-dune-lint#46).
The new version of dune (from 3.0.0) removed "dune external-lib-deps" and this is a patch that work with a patch of dune from "https://github.com/moyodiallo/dune/tree/opam-dune-lint".
There's already a PR(ocaml/dune#6045) in dune about this patch, but not guarantee to be merged. The command may change also.
This could be a temporary solution for our CI projects.
@tmcgilchrist