confirm / dialog #32
Merged
confirm / dialog #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to need to totally refactor tests after the last changes. I'll look at that tonight. |
jmervine
force-pushed
the
jmervine-confirm
branch
from
63ef46f to
2d79280
Compare
|
@jdorfman fixed tests and added usage, not sure if you want to include experimental stuff in the docs yet, but I don't suppose it's a blocker for merging to master... your call... merge if you're happy. |
|
I'm happy. Only took me 2 years ;) |
Closed
jmervine
force-pushed
the
jmervine-confirm
branch
from
ede6ff3 to
2a75c2d
Compare
|
@jdorfman Started with a rebase of master to kick this off again. |
- Addressing zsh source issue per #34 (comment). Thanks @simoniz0r for the tip. - Adding some basic checks to ensure that it sources correctly.
|
@jdorfman I'm going to leave it to you to update the documentation. |
|
@jmervine let's launch this. Worry about Homebrew after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #31 for full desc
@jdorfman please play with this and toss me some feedback
todo:
1.1.0https://maxcdn.github.io/shml/to http://shml.xyzPost-release: