-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Netlify redirects to host docs #268
Conversation
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..project-docs-redirect |
@jgerigmeyer looks like the redirect/rewrite is working. If you go to https://deploy-preview-268--oddleventy.netlify.app/herman/docs/ and inspect the source, you'll see the comment that I added here, so it's truly one site being served from another. I'll work on automating the docs generation from Herman releases. Once we have a good setup for Herman we can replicate it on the other repos and merge this PR. Let me know what you think of this solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerivas This approach looks good to me! Two thoughts:
- Would there be a way to get these redirects working in local development too? Right now it seems to result in a 404.
- For generating the docs, I think ideally we'd want them rebuilt every time there is a "latest" release created on GH.
* main: fix missing link Add GH action to check links First round fixing broken links.
I'll look into proxying the docs from their Netlify sites using eleventy's server. Or did you mean something local?
I'm experimenting with release triggers in my sandbox repo and it's working fine so far. Should have a PR ready for Herman tomorrow. |
Yeah, that's what I meant -- just so the links work in local development too. But that's a pretty minor point, so if it's not simple we could just replace those internal links with external links so they always work. |
It looks like we maybe want the |
* main: run checklinks action monthly try different link checker Try different package for checking external links More broken links test checklinks plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerivas This looks good, but I think we wait to merge this until all the relevant repo PRs are merged first, yes?
* main: Automated dependency upgrades Automated webmentions update
* main: (98 commits) Re-add event links to non-card view. tests AEA slides and unordered event lists update talks link sr-text Re-add date to oss/client pages. Remove date from tag detail pages Address review, and fix page summary margins Apply suggestions from code review remove oddbird events Remove padding from compact-events do not upgrade terser for now Downgrade rollup-terser until bugs are fixed remove webmention Automated dependency upgrades Automated webmentions update Use "range" dateformat for talks/workshops test review Ed quote, and talks on bird pages Address review ...
Todo:
I got this idea form the Netlify forum:
Right now I have created and populated the herman-docs repo manually, so the documentation for Herman should still work in this deploy preview. Up next we need to configure each project repo to push the built docs to the shadow repo, then we can merge this PR.