[services] Design and Development Services Page #59
Conversation
content/services/development.md
Outdated
| {% call layout.grid('narrow-columns') %} | ||
|
|
||
| {% call layout.block('item') %} | ||
|
|
There was a problem hiding this comment.
@mirisuzanne @jgerigmeyer I wasn't sure if line break matter as much here as they were in RST blog. I am not sure if we have a preferred amount of space between these calls and the end ones (there are three in a row after the second column of content).
There was a problem hiding this comment.
@stacyk Generally, spacing shouldn't matter too much – but it can have some impact on how the file is read as markdown. We don't have specific conventions, I tend to base it on what blocks are related or what seems most readable.
content/services/development.md
Outdated
|
|
||
| {% call layout.grid('narrow-columns') %} | ||
|
|
||
| {% call layout.block('item') %} |
There was a problem hiding this comment.
maybe call this grid-item or column-item or something that connects it to the narrow-columns grid? Alternately, consider using yaml data for these, like we do with icon blocks? We don't need to go that direction, but I tend to consider it when we otherwise need nested calls…
There was a problem hiding this comment.
I had it in the yaml, but I think it is more readable when the content is the order it appears on the page in general (plus I tend do always mess something up when it comes to yaml). I know we have content in the front matter for many parts of the site. I am old school ¯_(ツ)_/¯
There was a problem hiding this comment.
lol, yeah - I agree it's a trade-off. I'm just careful about nested calls, because I never understand how they handle context. But this seems to work, so I guess you got it right! 😂
There was a problem hiding this comment.
(Sidenote: Nunjucks is buggy and I don't trust it 😬)
There was a problem hiding this comment.
@mirisuzanne A few of the bugs from v3.0.0 have been fixed by v3.2.0... but there are still a number of bugs with scoping, especially as it relates to call and set blocks:
- Cannot reference outer scopes from inside a
{% call %}block. mozilla/nunjucks#679 - Issues with passing variables of parent macro to child macro mozilla/nunjucks#912
- Nested call/caller doesn't work. mozilla/nunjucks#664
- Call block fails to carry scope when outer macro uses {% set %} or keyword argument mozilla/nunjucks#1131
There was a problem hiding this comment.
@jgerigmeyer are you asking to change this to using the yaml content instead of what is in here now? I'm not sure what you are saying.
There was a problem hiding this comment.
@stacyk I wasn't saying that specifically, no. But I think we should all be vaguely aware of the existing bugs in Nunjucks, and hand-test any uses of caller (especially nested usage) or set to be sure it's actually working as we want.
* main: Re-add codepen. update redirects Adjust redirects. Fix CI Upgrade deps, docs. Update links to sites. Update homepage links. Remaining (known) link fixes. Start fixing external links Add remaining redirects (I think). Another round fixing broken links. Cleanup broken links and unused images Add checklinks netlify plugin. First pass at fixing/standardizing links.
* main: Upgrade JS deps. Stylguide fixes Remove duplicate svg viewbox/height/width (needs discussion). CSS-only click-anywhere-to-close on dropdown menues Add fieldset content wrapper for styling Upgrade deps, docs. Upgrade CCS Organize and document Radio cleanup Markup for new color controls
There was a problem hiding this comment.
@mirisuzanne can I not use /// @group type in different files? I see the title on the page is in the middle (split between two pages of css).
@stacyk you can - we just need to move that title to the "first place". It's not ideal, but ¯\_(ツ)_/¯ |
|
OK, I fixed the typography styleguide page title order. Back to @mirisuzanne for final review. |
* main: align pagination left Switch pagination order Fix oss sorting Fix tests. Fix posts sorting No more in-person conferences Simplify pagination markup, and fix a11y Add docs and (failing?) tests Style pagination Fix sorting and add dates paginate the main resource list
Cute animal pic
Link to Trello card (if applicable)
https://trello.com/c/bruLAag5/63-i-want-fleshed-out-content-for-the-design-and-development-service-detail-page
Description
The commit messages say what you did; this should explain why and/or how.
Checklist of progress is in Trello as well
Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
view the /services/development/ page and the XD File: https://xd.adobe.com/view/b8f11a7c-c6a3-4524-410f-d08c6df679b3-cec0/screen/bb6add8a-7784-40d2-b82b-e649fa02174c/Service-Tag-Page
Show me
Provide screenshots/animated gifs/videos if necessary.
WIP