Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to [email protected] #146

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

keithamus
Copy link
Collaborator

Description

TypeScript recently added definitions for popover which conflict with the ones in this repository.

This updates the TS definitions to be compatible with those from TypeScript, so that users of older versions of TypeScript will still get the types, and for users of newer versions the code won't run into type conflicts.

Steps to test/reproduce

Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).

$ git checkout origin/main -f
$ npm i typescript@latest -D
$ npm run build # observe the errrors!

Show me

Provide screenshots/animated gifs/videos if necessary.
N/A

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for popover-polyfill ready!

Name Link
🔨 Latest commit 281c230
🔍 Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/65524bfe9bf2470008bc5a1c
😎 Deploy Preview https://deploy-preview-146--popover-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* main:
  chore(deps): Automated dependency upgrades
@jgerigmeyer jgerigmeyer merged commit 48665d0 into main Nov 13, 2023
6 checks passed
@jgerigmeyer jgerigmeyer deleted the upgrade-to-typescript-5-2-2 branch November 13, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants