use standard text and background colors #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system colors are supported in every recent browser version `canvastext` `canvas` I don't know if we still need the fallbacks, or which browsers the polyfill supports. Otherwise we could do without the media-query.
nuxodin
requested review from
jerivas,
oluoluoxenfree,
sanajaved7,
keithamus and
jgerigmeyer
as code owners
keithamus
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Cool I never knew about these properties! According to MDN they've been supported since forever so I'd be happy to drop the media query too!
jgerigmeyer
approved these changes
Jan 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system colors are supported in every recent browser version:
canvastextcanvasI don't know if we still need the fallbacks, or which browsers the polyfill supports. Otherwise we could do without the media-query.
Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
Show me
Provide screenshots/animated gifs/videos if necessary.
REMEMBER: Attach this PR to the Trello card