add beforetoggle events #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also added the |
keithamus
force-pushed
the
add-beforetoggle-events
branch
2 times, most recently
from
59554d5 to
72ec2e6
Compare
keithamus
force-pushed
the
add-beforetoggle-events
branch
from
72ec2e6 to
a110af2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
beforetoggleevent which is defined by the spec: https://whatpr.org/html/8221/popover.html#show-popover. It also exposes the globalBeforeToggleEventwhich is a newEventsubclass that is exposed onwindow.The
beforetoggleevent has two properties:currentStateandnewState. They are set to'open'or'closed'based on the current and desired state of the popover. Thebeforetoggleevent when showing a popover is cancelable. The event when hiding a popover is not cancelable. This event does not bubble.Steps to test/reproduce
I've added tests for each of these conditions. Check out
events.spec.tsREMEMBER: Attach this PR to the Trello card