Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App owned: Add local IPFS implementation #375

Closed
wants to merge 15 commits into from
Closed

App owned: Add local IPFS implementation #375

wants to merge 15 commits into from

Conversation

bgins
Copy link
Member

@bgins bgins commented Apr 11, 2022 •
edited
Loading

Summary

This PR implements the following features

  • Add app-local IPFS node

Apps that use app-owned auth should not rely on the Fission Auth Lobby to provide them with a js-ipfs node. Instead, they should be able to run their own node.

Task list

  • Add localIps option
  • Add Worker implementation
  • Run IPFS from worker when localIpfs option is true
  • Report connection status events from worker

Test plan (required)

Closing issues

After Merge

  • Does this change invalidate any docs or tutorials? If so ensure the changes needed are either made or recorded
  • Does this change require a release to be made? Is so please create and deploy the release

@bgins bgins added this to the 🛂 App-Owned Accounts (W3S) milestone Apr 11, 2022
@bgins bgins mentioned this pull request Apr 11, 2022
Closed
@bgins bgins self-assigned this Apr 11, 2022
@bgins
Copy link
Member Author

bgins commented Apr 19, 2022

Discussed in: https://talk.fission.codes/t/aol-resource-creation-planning-and-discussion/2715

@bgins
Copy link
Member Author

bgins commented Apr 19, 2022

The initial version of this feature will only support browser environments. In the future, we can find a way to do something similar in node.

@bgins bgins mentioned this pull request Apr 19, 2022
Closed
bgins added 14 commits May 3, 2022 10:51
@bgins
Add localIpfs to InitOptions
e0f9335
@bgins
Add original shared worker and minified ifps
3b6690a
@bgins
Add ipfs worker build script
f954e61 
Bundles the worker and and copies ipfs.min.js into the lib directory.
@bgins
WIP: Load local IPFS worker
aeb62a8
@bgins
Load local IPFS only on auth success or continuation
43cd351
@bgins
Add connection status event emitter
8e79897
@bgins
Add shared worker for browsers that support it
505a6b4
@bgins
Move localIpfs check before loading filesystm
06661d3
@bgins
WIP: Convert IPFS worker to TypeScript
49fa45d
@bgins
Add check for local IPFS support
fb1c4b1 
The current UMD build does not support local IPFS. Add a check
and throw an exception when an app attempts to use local IPFS
with the single file UMD build.
@bgins
Add guard to local IPFS support check
6f19097 
We only want to check if localIpfs is true
@bgins
Download minified IPFS bundle
c1718d9 
Not ideal, but removes it from source control.
@bgins
WIP: Convert IPFS worker to TypeScript
27cb31d
@bgins
Clean up
504b7d1
@bgins bgins force-pushed the feature/local-ipfs branch from c1c57ef to 504b7d1 Compare May 3, 2022 18:03
@bgins
Copy link
Member Author

bgins commented Aug 10, 2022

Closed in favor or #404.

@bgins bgins closed this Aug 10, 2022
@icidasset icidasset deleted the feature/local-ipfs branch January 9, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@icidasset icidasset

@bgins bgins

Labels
🪒🦬 yak shaving
Projects
None yet
Milestone
🛂 App-Owned Accounts (W3S)
Development

Successfully merging this pull request may close these issues.
2 participants
@bgins @icidasset