Make MacOS releases self contained / bundle LLVM #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How much bigger will this be? |
|
It actually went down to 60MB because we are zipping it now. Here is a run I did on my fork: https://github.com/laytan/Odin/actions/runs/8010221628 if you want to check out the artifacts. |
|
Oh wow! This might be a great thing for everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all dynamic library dependencies bundle into
dist/libs.Just like before, macos will complain that the binary (and now additionally the bundled libraries) aren't signed/trusted, and you need to go to privacy settings to allow it to run.
To be clear, this already happened before this change with the binary.
This PR also makes the action zip up the dist folder, this is to keep the executable permissions when downloading it back, see actions/upload-artifact#38 for why.