Fix #1883 - Add descending sort to tooltips on match graphs #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason I can't see the original issue, e.g. https://www.opendota.com/matches/4156391118/graphs appears to have sorted tooltips. Do you have a match where this occurs? |
|
This is happening on all matches for me, including the one you linked. I tested it some more now and was able to recreate it on Chrome (on Win7 and Android) but not on Firefox. |
howardchung
approved these changes
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1883: Graph popups are not sorted by value in descending order
The tooltip when hovering over graphs will now sort correctly.