Merge pull request #8502 from mandy-chessell/oak2024

Allow DataAccessManagers to create external identifiers
odpi · Nov 21, 2024 · c6103a5 · c6103a5
2 parents 92cfb7a + bf113dc
commit c6103a5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.../openmetadata/adapters/connectors/unitycatalog/sync/OSSUnityCatalogServerSyncCatalog.java b/.../openmetadata/adapters/connectors/unitycatalog/sync/OSSUnityCatalogServerSyncCatalog.java
@@ -343,7 +343,7 @@ private void createElementInEgeria(CatalogInfo catalogInfo) throws InvalidParame
                                       qualifiedName,
                                       catalogTypeName,
                                       ucCatalogGUID,
-                                      OpenMetadataType.DATA_ACCESS_MANAGER.typeName,
+                                      catalogTypeName,
                                       this.getExternalIdentifierProperties(catalogInfo,
                                                                            null,
                                                                            UnityCatalogPlaceholderProperty.CATALOG_NAME.getName(),

diff --git a/.../main/java/org/odpi/openmetadata/frameworkservices/gaf/client/OpenMetadataClientBase.java b/.../main/java/org/odpi/openmetadata/frameworkservices/gaf/client/OpenMetadataClientBase.java
@@ -5194,6 +5194,7 @@ public void addExternalIdentifier(String                       userId,
 
         requestBody.setExternalScopeGUID(externalScopeGUID);
         requestBody.setExternalScopeName(externalScopeName);
+        requestBody.setExternalScopeTypeName(externalScopeTypeName);
 
         restClient.callVoidPostRESTCall(methodName,
                                         urlTemplate,

diff --git a/...org/odpi/openmetadata/integrationservices/catalog/connector/CatalogIntegratorContext.java b/...org/odpi/openmetadata/integrationservices/catalog/connector/CatalogIntegratorContext.java
@@ -541,9 +541,9 @@ public void addExternalIdentifier(String                       externalScopeGUID
         openMetadataStoreClient.addExternalIdentifier(userId,
                                                       externalScopeGUID,
                                                       externalScopeName,
+                                                      externalScopeTypeName,
                                                       openMetadataElementGUID,
                                                       openMetadataElementTypeName,
-                                                      externalScopeTypeName,
                                                       externalIdentifierProperties);
     }