-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate HTTP headers - Coco Pharma example #6977
Propagate HTTP headers - Coco Pharma example #6977
Conversation
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
|
…_pharma_example
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
…_pharma_example
The open metadata security samples project includes 2 connectors currently, both based on coco pharma
This PR proposes a http security connector, and in that it follows the existing sample. As such I don't have any issue with merging this in, but it does bring up two questions a) As the three connectors are seperately identfied/configured, do we want them in seperately deployable jars - this is how we usually do things - which would mean 3 artifacts. However we don't have to do this, ie if closely related |
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Outdated
Show resolved
Hide resolved
…hhtp_headers_coco_pharma_example
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Fixed
Show fixed
Hide fixed
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Fixed
Show fixed
Hide fixed
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
...odpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityProviderTokenBased.java
Show resolved
Hide resolved
...odpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityProviderTokenBased.java
Show resolved
Hide resolved
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Show resolved
Hide resolved
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/6977.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/6977.diff | git apply Once you're satisfied commit and push your changes in your project. Footnotes |
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
…hhtp_headers_coco_pharma_example
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Fixed
Show fixed
Hide fixed
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Fixed
Show fixed
Hide fixed
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. See minor comment about adding the example payload in the class javadoc.
.../odpi/openmetadata/metadatasecurity/samples/CocoPharmaServerSecurityConnectorTokenBased.java
Outdated
Show resolved
Hide resolved
.../odpi/openmetadata/metadatasecurity/samples/CocoPharmaServerSecurityConnectorTokenBased.java
Outdated
Show resolved
Hide resolved
...dpi/openmetadata/metadatasecurity/samples/CocoPharmaPlatformSecurityConnectorTokenBased.java
Show resolved
Hide resolved
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
Signed-off-by: Iliescu Cristian-Mihai <[email protected]>
I think we should keep the samples under single deployable jar (as is now). We can move the security connector samples to new repository if we decide in future but at this point it is just extra work and no value (The current samples are static, everything is hard coded. They do not provide value outside of the labs/tutorials) We should revisit the idea in the next iteration when we introduce connectors that integrate with LDAP and/or provide new services such as token based access control - parts discussed on the last workshop. |
Description
This change represents an example on how HTTP headers can be used for authorisation within a connector. This is a follow up to #6793 and #6851.
Testing
Functional testing