Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in headers and entity proxies detected by the CTS (#7148) #7247

Merged
merged 6 commits into from
Dec 21, 2022

Conversation

mandy-chessell
Copy link
Contributor

Description

There are three commits in this PR:

  • A fix to EntityProxy.java to only setup qualifiedName in the uniqueProperties if it is not null. This fixes the CTS failures.
  • A fix to Subject Area OMAS's relationship mappers that is needed to prevent an NPE in the FVTs once the above fix is in place.
  • A fix to set up the headerVersions in InstanceType, InstanceProperties and InstancePropertyValues.

The first two are good candidates to backport to 3.14. The third is optional.

Related Issue(s)

#7148

Testing

Run CTS with graph repository.

Release Notes & Documentation

Just bug fixes

@planetf1
Copy link
Member

Super!

I'd be inclined to take the fixes together and apply all.

I'm happy to create a 3.15 PR - but would either of you like to do it for practice (cherry-pick)?
I can also retest the cts on graph+inmem

@planetf1
Copy link
Member

The final commit to headers seems to break CTS. See referenced issue for more discussion

@mandy-chessell mandy-chessell dismissed planetf1’s stale review December 21, 2022 10:10

Because it is blocking merging

@mandy-chessell mandy-chessell merged commit f8d19ed into odpi:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants