Remove certs & application.properties from main jar #7693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR was to remove the application.properties, keystore.p12 and truststore.p12 from the main Egeria OMAGServerPlatform jar since it is causing problems for a production deployment of Egeria.
The knock on effects were:
When testing the script that generates the truststore and keystore I discovered that MacOS users needed to install openssl. I updated the readme for the script with instructions to describe how to do this.
Related Issue(s)
Testing
Rebuilt egeria and proved the FVTs are running - also checked that the platform comes up when run from the assembly. Regenerated the certificates and ensured they are copied to the correct new locations.
Release Notes & Documentation
The documentation around our assembly and the build of the jar files needs significant improvement to explain where different parts of an installation (particularly when using the containers) comes from and what needs to be changed for a production deployment.
Additional notes