OMAG server code stucture, actuator support and initial unit tests #7782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
lpalashevski
requested changes
Jul 17, 2023
...mplementation/server-chassis/server-chassis-spring/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...ver-chassis/server-chassis-spring/src/main/java/org/odpi/openmetadata/server/OMAGServer.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/odpi/openmetadata/server/config/AvailabilityProbesAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...mplementation/server-chassis/server-chassis-spring/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...mplementation/server-chassis/server-chassis-spring/src/main/resources/application.properties
Show resolved
Hide resolved
...hassis-spring/src/test/java/org/odpi/openmetadata/server/actuator/ActuatorEndpointsTest.java
Outdated
Show resolved
Hide resolved
lpalashevski
changed the title
lpalashevski
approved these changes
Jul 18, 2023
tijanapavicic
force-pushed
the
feature/initial-omag-server
branch
from
c7c3ed8 to
2a3c489
Compare
Signed-off-by: tijanapavicic <[email protected]>
Signed-off-by: tijanapavicic <[email protected]>
Signed-off-by: tijanapavicic <[email protected]>
Signed-off-by: tijanapavicic <[email protected]>
Signed-off-by: tijanapavicic <[email protected]>
tijanapavicic
force-pushed
the
feature/initial-omag-server
branch
from
2a3c489 to
7447ebc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } catch (IOException e) { | ||
| LOG.error("Exception while loading OMAG server configuration", e); | ||
| LOG.error("Failed loading OMAG server configuration with exception message : {}", e.getMessage()); |
Check warning
Code scanning / CodeQL
Unused format argument
| //TODO: Confirm if this is desired behaviour (configuration is null) | ||
| // Same as in the case above. | ||
| throw new ApplicationContextException("Exception loading OMAG server configuration"); | ||
| throw new ApplicationContextException( | ||
| String.format("Failed loading OMAG server configuration with exception message : {}", e.getMessage())); |
Check warning
Code scanning / CodeQL
Unused format argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial setup with whitelisting health actuator endpoints, and basic unit test coverage for OMAGServer class.
Related Issue(s)
Testing
Release Notes & Documentation
Additional notes