Correct report utilitiy packages and simplify connector providers #7855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
mandy-chessell
requested review from
planetf1,
davidradl,
lpalashevski,
lcpopa and
cmgrote
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| public void checkServerTrusted( | ||
| java.security.cert.X509Certificate[] certs, String authType) { | ||
| public void checkServerTrusted(java.security.cert.X509Certificate[] certs, String authType) |
Check notice
Code scanning / CodeQL
Missing Override annotation
| public java.security.cert.X509Certificate[] getAcceptedIssuers() { | ||
| return new X509Certificate[0]; | ||
| } | ||
| public void checkClientTrusted( | ||
| java.security.cert.X509Certificate[] certs, String authType) { | ||
| public void checkClientTrusted(java.security.cert.X509Certificate[] certs, String authType) |
Check notice
Code scanning / CodeQL
Missing Override annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the packages for the report utilities so theie main class matches the name specified in the build.gradle file.
There is also a change to most connectors' provider class to pass the name of the connector as a string, rather than loading the connector class to retrieve its name. This is to allow the connector provider to be used (for example in the component-id-report) without needing to pull in all of the dependencies of the connector implementation.
The connector-id-report has been updated to include the integration connectors and new resource connectors. The governance services are not yet included because their connector providers need updating to declare their component id.
Related Issue(s)
These issue were found during testing of the 4.3 release (#7794)
Testing
FVT, labs, running utilities from install image plus running additional private connectors.
Release Notes & Documentation
Updates to egeria-docs ar being made in parallel.
Additional notes
None