Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey Action Framework (SAF) #7999

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

mandy-chessell
Copy link
Contributor

Description

This is the initial implementation of the Survey Action Framework (SAF) with an implementation of three survey action services. The aim is to share the new programming model with examples.

Related Issue(s)

None

Testing

Just regression tests with FVT. These services can not run until the Survey Action OMES and the SAF client in Stewardship Action OMES is written.

Release Notes & Documentation

Additional notes

The new survey action services have been included in the OpenConnectorArchive.omarchive builder. However they are not able to run so the archive file has not been updated in content-packs.

@mandy-chessell
Copy link
Contributor Author

There is also a fix to the XTDB connector to build and use a Fat Jar in the assemblies.

@mandy-chessell mandy-chessell merged commit 1fdfdbf into odpi:main Jan 10, 2024
4 checks passed
", requestParameters=" + requestParameters +
", assetStore=" + assetStore +
", annotationStore=" + annotationStore +
", openMetadataStore=" + openMetadataStore +

Check notice

Code scanning / CodeQL

Use of default toString() Note

Default toString(): SurveyOpenMetadataStore inherits toString() from Object, and so is not suitable for printing.

CSVFileStoreConnector assetConnector = (CSVFileStoreConnector)connector;

int delimiterCount = 0;

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'int delimiterCount' is never read.
* @throws UserNotAuthorizedException the governance action service is not authorized to archive this element
* @throws PropertyServerException there is a problem with the metadata store
*/
public void archiveMetadataElementInStore(String userId,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
MetadataElementInterface.archiveMetadataElementInStore
; it is advisable to add an Override annotation.
* @throws UserNotAuthorizedException the governance action service is not authorized to archive this element
* @throws PropertyServerException there is a problem with the metadata store
*/
public void archiveMetadataElementInStore(String userId,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
MetadataElementInterface.archiveMetadataElementInStore
; it is advisable to add an Override annotation.
delimiterCount = position - 1;
}

for (int recordNumber=0; recordNumber < recordCount ; recordNumber++)

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition High

Comparison between
expression
of type int and
expression
of wider type long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant