Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-refresh to integration daemon #8328

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

mandy-chessell
Copy link
Contributor

Description

This feature enhances the integration daemon so that is issues a refresh to an integration connector when it is given a new catalog target.

  • the governance Server OMAS has an new event type for a change in an integraiton connectors catalog target relationships.
  • the integration daemon services receive this event, identify which integration connector is affected and calls refresh on that connector.

The UnityCalalogInsideCatalogSyncConnector has also been enhanced to listen for new metadata elements being added to one of the metadata collections that match the catalogs it is synchronizing. It then immediately pushes them to Unity Catalog.

Finally there are changes to the governance action samples to experiment with a new capability that enabled governance action types and governance action processes to have predefined request parameters and action targets defined so they do not have to be supplied by the caller. If the caller does supply these values, they override the pre-defined values.

Related Issue(s)

During testing I discovered that some of the valid values associated with Eums was missing. Most particularly, the TodDoStatus only has 3 values. This was due to three of the values haveing the came guid and so the CoreContentPack overwrote the entries with the same guid.

The testing also revealed issues when toDos were created in that the AsignedTo relationship ends were reversed

Testing

The new governance -action-samples were used to test this function.

Release Notes & Documentation

There are 2 new relationships defined in the open types:

  • TargetForActionType
  • TargetForActionProcess

The GovernanceActionProcessFlow relationship has a new property called requestParameters. These are all for the predefined action targets and request parameters.

the updates to the type descriptions are in a PR for egeria-docs.

Additional notes

None

@mandy-chessell mandy-chessell merged commit b3734e2 into odpi:main Aug 19, 2024
4 checks passed
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

element.getElementGUID(),
publishZones.toString()));
}
auditLog.logMessage(methodName,

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
auditLog
may be null at this access as suggested by
this
null guard.
governanceContext.recordCompletionStatus(completionStatus, outputGuards);
if (messageDefinition != null)
{
auditLog.logMessage(methodName, messageDefinition);

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
auditLog
may be null at this access as suggested by
this
null guard.

if (integerOption != null)
{
return Integer.parseInt(integerOption);

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

if (integerOption != null)
{
return Long.parseLong(integerOption);

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.
String processOwnerGUID = null;
String processOwnerTypeName = null;
String custodianGUID = null;
String custodianTypeName = null;

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String custodianTypeName' is never read.
String processOwnerTypeName = null;
String custodianGUID = null;
String custodianTypeName = null;
String hospitalContactGUID = null;

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String hospitalContactGUID' is never read.
String custodianGUID = null;
String custodianTypeName = null;
String hospitalContactGUID = null;
String hospitalContactTypeName = null;

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String hospitalContactTypeName' is never read.
* @throws ConnectorCheckedException there is a problem within the governance action service.
*/
@Override
public void start() throws ConnectorCheckedException

Check warning

Code scanning / CodeQL

Non-synchronized override of synchronized method Warning

Method 'start' overrides a synchronized method in
org.odpi.openmetadata.frameworks.governanceaction.GeneralGovernanceActionService
but is not synchronized.
* @throws ConnectorCheckedException there is a problem within the governance action service.
*/
@Override
public void start() throws ConnectorCheckedException

Check warning

Code scanning / CodeQL

Non-synchronized override of synchronized method Warning

Method 'start' overrides a synchronized method in
org.odpi.openmetadata.frameworks.governanceaction.GeneralGovernanceActionService
but is not synchronized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant