Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Coco Data Quality Sample #8337

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

mandy-chessell
Copy link
Contributor

Description

This PR includes miscellaneous fixes for issues detected while running the new data quality sample connector CocoClinicalTrialCertifyWeeklyMeasurementsService.

Related Issue(s)

None

Testing

Manula testing of data quality sample

Release Notes & Documentation

Just bug fixes

Additional notes

None

@mandy-chessell mandy-chessell merged commit 49f5b56 into odpi:main Aug 28, 2024
4 checks passed
@@ -176,7 +178,7 @@
* @throws FileException problem accessing the file
* @throws FileReadException unable to find, open or read the file, or the file does not include the requested record.
*/
public List<String> readRecord(int dataRecordNumber) throws FileException, FileReadException
public List<String> readRecord(long dataRecordNumber) throws FileException, FileReadException

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
CSVFileStore.readRecord
; it is advisable to add an Override annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant