Fixes to Asset Lineage Graph #8454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the node identifier in the Asset Lineage Mermaid graph to use the GUID rather than a mangled qualifiedName (mermaid does not allow spaces in its identifiers). This change means it is easier to audit the graph at a later time because each node can be looked up via the open metadata APIs.
In addition, one of the nodes was not displaying property.
This turned out to be an error in the use of
subList(startingIndex, endingIndex)as theendingIndexis exclusive rather than inclusive. The reult of this fix, the graph displays completely:Related Issue(s)
None
Testing
Manual check of graph display
Release Notes & Documentation
This is a bug fix
Additional notes
None