Enable deeply nested virtual connections/connectors #8487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * | ||
| * @return Connection bean | ||
| */ | ||
| protected VirtualConnection getConnectionBean() |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Open Connector Framework (OCF) to allow deeply nested virtual connections. This issue was uncovered by the PostgreSQL repository connector that uses a nested JDBC Resource Connector with a nested secrets connector.
The OCF's ConnectorBroker and the VirtualConnector beans were assuming a nested connection was a plain connection rather than a nested connection. This object is cast multiple times and any embedded virtual connection is lost.
Related Issue(s)
None
Testing
Testing start up of the PostgeSQL Repository Connector with security turned on
Release Notes & Documentation
Need to add description on the security access needed by a postgreSQL repository connector.
Additional notes
The container
additional.propertiesis now using the 5442 port for the PostgreSQL server to match the database port inegeria_workspaces.