Add cloud information model archive builder #8503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+188
to
+192
| String propertyTermId = archiveHelper.addTerm(glossaryId, | ||
| categoryList, | ||
| propertyGroup. getGUID() + propertyGroup.getTechnicalName() + ":" + propertyDescription.getTechnicalName(), | ||
| propertyDescription.getDisplayName(), | ||
| propertyDescription.getDescription()); |
Check notice
Code scanning / CodeQL
Unread local variable Note
Comment on lines
+269
to
+273
| String conceptTermId = archiveHelper.addTerm(glossaryId, | ||
| categoryList, | ||
| "SubjectArea:" + subjectArea.getTechnicalName() + ":" + ":" + conceptGroup.getGUID() + concept.getTechnicalName(), | ||
| concept.getDisplayName(), | ||
| concept.getDescription()); |
Check notice
Code scanning / CodeQL
Unread local variable Note
| { | ||
| System.out.println("\nRetrieving model contents from: " + cimContentFile.getName()); | ||
|
|
||
| Map<String, Object> modelJsonLD = (LinkedHashMap<String, Object>) JsonUtils.fromInputStream(new FileInputStream(cimContentFile)); |
Check warning
Code scanning / CodeQL
Potential input resource leak Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the archive build that converts the Cloud Information Model JSON LD format into a gloassary. There are multiple errors in the JSONLD file and so this is a temporary measure until we can create a way to maintain the content.
This addition allowed us to rebuild the CloudInformationModel.omarchive to correct errors in the way Enums are stored - and to add the RootCategery classification to the top-level category.
Related Issue(s)
PostgreSQL Repository Connector
I noticed a problem in the saving of new versions of an entity in that it was adding the classifications as if they were new. This meant that the classification/classification attributes tables were accumulating multiple active versions of the same classification. This only occurred when the entity was updated.
Testing
Loading multiple versions of the core content pack into the repository. This showed the classification loading problem that was fixed above.
Loading the regenrated CloudInformationModel archive to check that it loaded without error.
Release Notes & Documentation
The CloudInformaitonModel archive is already documented - this PR just adds the capability to maintain it.
Additional notes
none