Construct public URL for uploads #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'uniqueFilename' option is specified, newly created object will be named after generated UUID and original filename is not used at all.
In case S3 bucket is configured in static website hosting mode, it is convenient to tell the client the public URL of newly created object to access it directly (instead of going through s3router redirection). Also, providing the function instead, it is possible to generate custom URL for example, if there a CDN or custom domain name configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case uploaded file becomes public-readable (due to bucket or object permissions or in case there is CDN distribution configured), it might be convenient to send object's public URL to the client to avoid going through temporary redirects in s3router.
Also add an option to construct object keys based solely on UUID and don't append original filename.