Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow issue #126

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix overflow issue #126

wants to merge 3 commits into from

Conversation

sdrapha
Copy link
Contributor

@sdrapha sdrapha commented May 23, 2022

Fix drop-down incompatibility with the card
Issue #120

@sdrapha sdrapha changed the title Fix overflow issue #120 Fix overflow issue May 23, 2022
@ofekashery
Copy link
Owner

Thank you, @sdrapha. How does this change affect the border radius? The borderRadius of the inside cards is 0, and removing the overflow: hidden may break the style.

@sdrapha
Copy link
Contributor Author

sdrapha commented Feb 21, 2023

I just noticed it now, that is true.

But when I made the PR, 10 months ago, HomeAssistant didn't have rounded corners on the cards, so that was no issue at all.

Althought this is a side-effect in the current homeassistant theme, the benefits of having the input selects in a working state is very important, otherwise I wouldn't use this card at all. I can live with a little point on the corners of some cards, notice it's not all of them, some already have rounded corners as well. And, as last resource, card-mod can fix the issue in each individual iiner card.

Example:
image

@sdrapha
Copy link
Contributor Author

sdrapha commented Feb 21, 2023

I just pushed a new commit to fix the border radius issue as well

image
No sharp corners anymore.

@dermotduffy
Copy link

FYI: This also impacts the Frigate card which renders a drop-down menu. That menu may be "cut off" when the overflow is hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants