Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various README.md refinements and additions #183

Closed
wants to merge 1 commit into from
Closed

Various README.md refinements and additions #183

wants to merge 1 commit into from

Conversation

felikcat
Copy link

@felikcat felikcat commented Dec 8, 2021

App Store section

  • Add separator for Google Play Store.
  • Add apps: SkyDroid, and Droid-ify.

Browser section

  • Separate into Updaters, Firefox, and Chrome.
  • Add apps: Iceraven, Mull, and Kiwi Browser.

Document & PDF Viewer section

  • Add apps: Secure PDF Viewer.

Messaging section

  • Separate into XMPP, Matrix, Telegram, and Signal.
  • Add apps: Briar, NekoX, and SchildiChat.

File formatting

  • Make the double newline between sections consistent.
  • Sort all sections and their entries by alphabetical order (A-Z).

Notes: Faults within CONTRIBUTING.md

  1. "Please do not submit third party repositories."
  • Vague description. Does this also factor in apps using an external updater like FFUpdater, or only F-Droid?
  1. "No proprietary elements"
  • The official Firefox has proprietary elements; Fennec's whole purpose is to strip those proprietary elements out of Firefox. From this current contridiction, Kiwi Browser has been left added.

== App Store section ==
* Add separator for Google Play Store.
* Add apps: SkyDroid, and Droid-ify.

=== Browser section ===
* Separate into Updaters, Firefox, and Chrome.
* Add apps: Iceraven, Mull, and Kiwi Browser.

=== Document & PDF Viewer section ===
* Add apps: Secure PDF Viewer.

=== Messaging section ===
* Separate into XMPP, Matrix, Telegram, and Signal.
* Add apps: Briar, NekoX, and SchildiChat.

=== File formatting ===
* Make the double newline between sections consistent.
* Sort all sections and their entries by alphabetical order (A-Z).
- [**Yalp Store**](https://github.com/yeriomin/YalpStore) <sup>**[[F-Droid](https://f-droid.org/app/com.github.yeriomin.yalpstore)]**</sup>
- [**G-Droid**](https://gitlab.com/gdroid/gdroidclient/) <sup>**[[F-Droid](https://f-droid.org/app/org.gdroid.gdroid)]**</sup>
- [**M-Droid**](https://github.com/SkyzohKey/M-Droid) <sup>**[[F-Droid](https://f-droid.org/app/com.mdroid)]**</sup>
- [**SkyDroid**](https://apt.izzysoft.de/fdroid/index/apk/app.skydroid)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the official project instead of 3rd party distribution.

- [**Bromite**](https://www.bromite.org/)
- [**DuckDuckGo Privacy Browser**](https://github.com/duckduckgo/Android) <sup>**[[F-Droid](https://f-droid.org/app/com.duckduckgo.mobile.android)]**</sup>
- [**SmartCookieWeb**](https://github.com/CookieJarApps/SmartCookieWeb) <sup>**[[F-Droid](https://f-droid.org/app/com.cookiegames.smartcookie)]**</sup>
- [**Privacy Browser**](https://gitweb.stoutner.com/?p=PrivacyBrowser.git) <sup>**[[F-Droid](https://f-droid.org/app/com.stoutner.privacybrowser.standard)]**</sup>
- [**Kiwi Browser**](https://kiwibrowser.com/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Kiwi; is it really an Open Source project?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Kiwi; is it really an Open Source project?

Tobi823/ffupdater#35
It is supposedly spywear. I am not a dev, so can someone confirm this issue is legit for me?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link. From the discussion it looks very suspicious for me. Better don't add it (at least for now).

Copy link
Contributor

@shuvashish76 shuvashish76 Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a developer either.
https://github.com/kiwibrowser/src/blob/master/LICENSE

Kiwi source code is open but as they haven't mentioned any GPL-Compatible or Apache license. No FOSS license means project not opensource. License is important, F-Droid always check license 1st ( check their Inclusion-policy)

Plus check: https://github.com/kiwibrowser/src#business-model

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the license looks like a BSD 4-clause. GH probably doesn't recognise it because of the //.

However, due to the linked business model it's … debatable …

If there's no strong opinion for adding it, I'd suggest leaving it out for now.

Btw. there's RFP on F-Droid: https://gitlab.com/fdroid/rfp/-/issues/906

- [**Librera Reader**](https://github.com/foobnix/LibreraReader) <sup>**[[F-Droid](https://f-droid.org/app/com.foobnix.pro.pdf.reader)]**</sup>
- [**MuPDF**](http://mupdf.com/) <sup>**[[F-Droid](https://f-droid.org/app/com.artifex.mupdf.viewer.app)]**</sup>
- [**Pdf Viewer Plus**](https://github.com/JavaCafe01/PdfViewer) <sup>**[[F-Droid](https://f-droid.org/app/com.gsnathan.pdfviewer)]**</sup>
- [**Secure PDF Viewer**](https://github.com/GrapheneOS/PdfViewer) <sup>**[[Google Play](https://play.google.com/store/apps/details?id=org.grapheneos.pdfviewer)]**</sup>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [**Secure PDF Viewer**](https://github.com/GrapheneOS/PdfViewer) <sup>**[[Google Play](https://play.google.com/store/apps/details?id=org.grapheneos.pdfviewer)]**</sup>
- [**Secure PDF Viewer**](https://github.com/GrapheneOS/PdfViewer)

No Google Play please.

Btw. from discussion here (https://github.com/GrapheneOS/PdfViewer/issues/75, https://github.com/GrapheneOS/PdfViewer/issues/63) it's not F-Droid due to some technical reasons, but not by the app itself. 👍

@offa
Copy link
Owner

offa commented Dec 8, 2021

Huge thank you! 🎉

Introducing sub section gives quite some structure.

Vague description. Does this also factor in apps using an external updater like FFUpdater, or only F-Droid?

Good point. It's related to the app source only. Eg. FFUpdater is fine since it's in the official F-Droid repo.

The official Firefox has proprietary elements; Fennec's whole purpose is to strip those proprietary elements out of Firefox. From this current contridiction, Kiwi Browser has been left added.

That's true – and a good reason to drop Firefox. 👍

@Paiusco
Copy link
Contributor

Paiusco commented Dec 24, 2021

@offa should a better explanation on what Utilities and Miscellaneous stays for? I think it'd be nice to create more categories instead...

@offa
Copy link
Owner

offa commented Dec 27, 2021

At the moment both are some kind of "what doesn't fit somewhere else". If you have some ideas, suggestions / PRs are always welcome! 👍

- [**Audio Anchor**](https://github.com/flackbash/AudioAnchor) <sup>**[[F-Droid](https://f-droid.org/app/com.prangesoftwaresolutions.audioanchor)]**</sup>
- [**Escapepod**](https://github.com/y20k/escapepod) <sup>**[[F-Droid](https://f-droid.org/app/org.y20k.escapepod)]**</sup>
- [**MaterialAudiobookPlayer**](https://github.com/PaulWoitaschek/MaterialAudiobookPlayer) <sup>**[[F-Droid](https://f-droid.org/app/de.ph1b.audiobook)]**</sup>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is called "Voice", would make sense to rename it in this list.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@offa
Copy link
Owner

offa commented Jan 25, 2022

ping @nermur; not much to change, let me know and can fix the rest :-)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants