feat: Make linkable throw when a glob in .linkable.json leads to no p…

…ackage.json
ogre-works · Sep 12, 2023 · be952b6 · be952b6
1 parent 38cd379
commit be952b6
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 11 deletions.
diff --git a/packages/linkable/src/create-links.test.ts b/packages/linkable/src/create-links.test.ts
@@ -162,10 +162,11 @@ describe('create-links', () => {
 
             await globMock.resolve([
               '/some-directory/some-monorepo/packages/some-other-directory/some-module/package.json',
-              '/some-directory/some-monorepo/packages/some-other-directory/some-other-module/package.json',
             ]);
 
-            await globMock.resolve([]);
+            await globMock.resolve([
+              '/some-directory/some-monorepo/packages/some-other-directory/some-other-module/package.json',
+            ]);
           });
 
           it('reads contents of package.jsons', () => {
@@ -180,6 +181,22 @@ describe('create-links', () => {
             ]);
           });
         });
+
+        describe('when one of discoveries resolves with nothing', () => {
+          beforeEach(async () => {
+            readJsonFileMock.mockClear();
+
+            await globMock.resolve([]);
+
+            globMock.resolve(['irrelevant']);
+          });
+
+          it('throws about bad path', () => {
+            return expect(actualPromise).rejects.toThrow(
+              'Tried to linkable-link: "../some-monorepo/packages/**/*/package.json" from "/some-directory/some-project/.linkable.json", but no package.jsons were found.',
+            );
+          });
+        });
       });
 
       describe('when config file resolves with module paths', () => {

diff --git a/packages/linkable/src/get-package-jsons/get-package-json-paths.injectable.ts b/packages/linkable/src/get-package-jsons/get-package-json-paths.injectable.ts
@@ -2,7 +2,7 @@ import { getInjectable } from '@ogre-tools/injectable';
 import { workingDirectoryInjectable } from '../shared/working-directory.injectable';
 import type { Config } from '../config/get-config.injectable';
 import { pipeline } from '@ogre-tools/fp';
-import { map, flatten } from 'lodash/fp';
+import { map, flatMap, tap } from 'lodash/fp';
 import { globInjectable } from '../shared/fs/glob.injectable';
 import { awaitAll } from '../await-all';
 
@@ -17,17 +17,41 @@ export const getPackageJsonPathsInjectable = getInjectable({
       pipeline(
         config,
 
-        map(modulePathGlob =>
-          glob(`${modulePathGlob}/package.json`, {
-            cwd: workingDirectory,
-            ignore: ['**/node_modules/**/*'],
-            absolute: true,
-          }),
-        ),
+        map(async modulePathGlob => {
+          const globString = `${modulePathGlob}/package.json`;
+
+          return {
+            globString: globString,
+
+            packageJsonPaths: await glob(globString, {
+              cwd: workingDirectory,
+              ignore: ['**/node_modules/**/*'],
+              absolute: true,
+            }),
+          };
+        }),
 
         awaitAll,
 
-        flatten,
+        tap(checkForGlobMatchesFor(workingDirectory)),
+
+        flatMap('packageJsonPaths'),
       );
   },
 });
+
+const checkForGlobMatchesFor =
+  (workingDirectory: string) =>
+  (results: { globString: string; packageJsonPaths: any[] }[]) => {
+    const globStringsForNoMatches = results
+      .filter(x => !x.packageJsonPaths.length)
+      .map(x => x.globString);
+
+    if (globStringsForNoMatches.length) {
+      throw new Error(
+        `Tried to linkable-link: "${globStringsForNoMatches.join(
+          '", "',
+        )}" from "${workingDirectory}/.linkable.json", but no package.jsons were found.`,
+      );
+    }
+  };