Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key name conflicts with Play SBT plugin #4

Closed
kevin-lee opened this issue Jun 4, 2015 · 0 comments · Fixed by #5
Closed

Key name conflicts with Play SBT plugin #4

kevin-lee opened this issue Jun 4, 2015 · 0 comments · Fixed by #5

Comments

@kevin-lee
Copy link
Contributor

The key assets conflicts with the key, assets, in the SBT plugin for Play framework.
So when both are put in the plugins.sbt file and either or both are used in the build.sbt or Build.scala, it causes the following exception.

Some keys were defined with the same name but different types: 'assets' (sbt.Task[java.io.File], sbt.Task[scala.collection.Seq[java.io.File]])

Play framework is such a popular framework so I think it is better to avoid that conflict then doing any extra work to avoid it when using it. And I'm not sure if there is any easy workaround for this.

I've changed the assets to releaseAssets in my forked repo of sbt-github-release and will deploy it to my Bintray repo to test it properly. If it works well, I'll create a pull request. So please consider my suggestion.
kevin-lee added a commit to kevin-lee/sbt-github-release that referenced this issue Jun 4, 2015
@kevin-lee
This fixes ohnosequences#4
41ec20d 
It will be deployed and tested before creating a pull request.
@kevin-lee kevin-lee mentioned this issue Jun 4, 2015
Merged
laughedelic added a commit that referenced this issue Jun 4, 2015
@laughedelic
Setting version to 0.3.0:
5481ba7 
- Fixed key name conflict with Play plugin's (#4/#5 by @kevin-lee)

  ```
  Some keys were defined with the same name but different types: 'assets' (sbt.Task[java.io.File], sbt.Task[scala.collection.Seq[java.io.File]])
  ```

  `assets` key is renamed to `releaseAssets`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix key name conflict with Play SBT plugin kevin-lee/sbt-github-release
1 participant
@kevin-lee