Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto pause aurora serverless cluster #1

Closed
wants to merge 1,060 commits into from
Closed

Auto pause aurora serverless cluster #1

wants to merge 1,060 commits into from

Conversation

ViktorCollin
Copy link

@ViktorCollin ViktorCollin commented Nov 27, 2024 •
edited
Loading

Description

This is my first time working in Go, so please bare with me if there is anything I did not get correctly

This is a continuation of #40230 by ohookins

Original PR:
https://aws.amazon.com/blogs/database/introducing-scaling-to-0-capacity-with-amazon-aurora-serverless-v2

Aurora Serverless now supports scaling to 0 (previously the minimum was 0.5). There are some additional checks around specific versions of the engine (e.g. PostgreSQL versions) but these are likely to change reasonably frequently and may not be wise to encode in the provider. API checks at runtime will error out if an incompatible engine version is selected.

Addition:
There is a parameter called seconds_until_auto_pause that allows for configuring how long time the instances have to be inactive before they are paused

Relations

Closes #40226

References

https://aws.amazon.com/blogs/database/introducing-scaling-to-0-capacity-with-amazon-aurora-serverless-v2

Output from Acceptance Testing

Same issue as in te original PR

JanuaryThomas
JanuaryThomas approved these changes Nov 30, 2024
View reviewed changes
Copy link

@JanuaryThomas JanuaryThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into similar functionality

@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/serverlessapplicationrepo…
b5285b5 
…sitory.
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/servicecatalog.
f719913
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/servicecatalogappregistry.
1a62210
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/servicediscovery.
6810bd2
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/servicequotas.
3d23fc1
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/ses.
b17c92c
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/sesv2.
a8c531e
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/sfn.
846f415
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/shield.
215e1b3
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/signer.
8dd695e
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/sns.
ffada48
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/sqs.
d8592d9
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/ssm.
3e31188
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/ssmcontacts.
383c4dd
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/ssmincidents.
24f0ff9
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/ssmquicksetup.
dc4e158
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/ssmsap.
b1d0ccc
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/ssoadmin.
7e60c7b
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/storagegateway.
67a6c3a
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/swf.
21960ca
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/synthetics.
0f3abe3
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/taxsettings.
b3916d5
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb.
b7343a0
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/timestreamwrite.
9082b36
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/transcribe.
dc1d807
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/transfer.
81db023
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/verifiedpermissions.
594cc6f
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/vpclattice.
b6a34d9
@ewbankkit
go get github.com/aws/aws-sdk-go-v2/service/waf.
cacf6c8
changelogbot and others added 28 commits December 3, 2024 21:53
Update CHANGELOG.md for hashicorp#40339
c9525b0
@gdavison
Fixes copyloopvar linting errors
4badbf5
@gdavison
tfproviderdocs doesn't treat newline and space as equivalent
9cc60bf
@gdavison
Removes deprecated variable interpolation
b88c7ea
@gdavison
More tfproviderdocs doesn't treat newline and space as equivalent
203a811
@gdavison
Required phrasing
533bd2c
@gdavison
Merge pull request hashicorp#40420 from hashicorp/f-s3tables
51769a8 
New Service: `s3tables`
Update CHANGELOG.md for hashicorp#40420
e822fef
@YakDriver
docs: Better document perpetual diffs
af8e331
@YakDriver
Add documentation for perpetual diffs
62dfb39
@YakDriver
Linty Claus
74264a0
@YakDriver
Linty Claus
e611c7f
@dependabot
Bump the aws-sdk-go-v2 group across 1 directory with 5 updates
420b15e 
Bumps the aws-sdk-go-v2 group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go-v2/service/athena](https://github.com/aws/aws-sdk-go-v2) | `1.48.5` | `1.49.0` |
| [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) | `1.43.2` | `1.43.3` |
| [github.com/aws/aws-sdk-go-v2/service/datazone](https://github.com/aws/aws-sdk-go-v2) | `1.24.1` | `1.25.0` |
| [github.com/aws/aws-sdk-go-v2/service/glue](https://github.com/aws/aws-sdk-go-v2) | `1.102.1` | `1.103.0` |
| [github.com/aws/aws-sdk-go-v2/service/redshiftserverless](https://github.com/aws/aws-sdk-go-v2) | `1.24.4` | `1.25.0` |



Updates `github.com/aws/aws-sdk-go-v2/service/athena` from 1.48.5 to 1.49.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/eks/v1.48.5...service/s3/v1.49.0)

Updates `github.com/aws/aws-sdk-go-v2/service/cloudwatch` from 1.43.2 to 1.43.3
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/ssm/v1.43.2...service/ssm/v1.43.3)

Updates `github.com/aws/aws-sdk-go-v2/service/datazone` from 1.24.1 to 1.25.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@v1.24.1...v1.25.0)

Updates `github.com/aws/aws-sdk-go-v2/service/glue` from 1.102.1 to 1.103.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/ec2/v1.103.0/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/glue/v1.102.1...service/ec2/v1.103.0)

Updates `github.com/aws/aws-sdk-go-v2/service/redshiftserverless` from 1.24.4 to 1.25.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/pi/v1.24.4...v1.25.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/athena
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/datazone
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/glue
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/redshiftserverless
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk-go-v2
...

Signed-off-by: dependabot[bot] <[email protected]>
@breathingdust @github-actions
docs: update resource counts
d036132
@ewbankkit
Merge pull request hashicorp#40434 from hashicorp/resource-counts
fb73986 
docs: update resource counts
@ewbankkit
Merge pull request hashicorp#40432 from hashicorp/dependabot/go_modul…
5afb09a 
…es/aws-sdk-go-v2-589d3b4213

Bump the aws-sdk-go-v2 group across 1 directory with 5 updates
@ewbankkit
Merge branch 'main' into HEAD
bc61816
@ewbankkit
Add CHANGELOG entry.
71b1300
@ewbankkit
Tweak 'TestAccRDSCluster_serverlessV2ScalingConfiguration'.
f1eb05e
@ewbankkit
Update documentation.
bbc3f5a
@YakDriver
Merge pull request hashicorp#40428 from hashicorp/d-document-rds-para…
66b416d 
…meter-group-diffs

docs: Better document perpetual diffs
@jar-b
Merge pull request hashicorp#40279 from stefanfreitag/f-aws_bedrockag…
d66c6ee 
…ent_agent-update-instructions-validation

feat: update max length for bedrock agent instructions
@ewbankkit
Merge pull request hashicorp#40230 from ohookins/40226-zero-capacity-…
33689a1 
…aurora-serverless-scaling

Allow Aurora Serverless scaling to zero capacity.
@johnsonaj
Merge pull request hashicorp#40409 from hashicorp/f-rds_instance_clus…
df9c839 
…ter_replica_delete

r/aws_rds_cluster_instance: fix destroy error when cluster instance is in a read replica
Update CHANGELOG.md for hashicorp#40409
9273b07
@ViktorCollin
Merge branch 'main' of https://github.com/hashicorp/terraform-provide…
a2ecab7 
…r-aws into auto-pause-aurora-serverless-cluster
@ViktorCollin
fix: formatting in test
2efcbe0
@ViktorCollin
fix: match documentation from main
a357a81
@ViktorCollin
Copy link
Author

I created a new PR directly to hashicorps repository as the original PR got merged without my additions. The new PR can be found here hashicorp#40441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuaryThomas JanuaryThomas JanuaryThomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support scaling to zero capacity for aurora serverless v2 instance