Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcgi 1413 move failed report plugin to summary #489

Merged
merged 31 commits into from
Jan 22, 2025

Conversation

AqsaAlam
Copy link
Collaborator

@AqsaAlam AqsaAlam commented Nov 7, 2024

Bitbucket incoming
Did not run mini djerba tests

iainrb and others added 4 commits November 7, 2024 12:41
iainrb and others added 22 commits November 11, 2024 16:47
Update 1.7.8 with latest changes from main
…manual-ids

Allowed tumour and normal ids to be manually specified for provenance helper
…TS40X

Added oncokb definitions to 40x assays
* Debugging

* Debugging

* Update clinically relevant variants count to reflect unique fusions after filtering by OncoKB levels

* Update test checksum

---------

Co-authored-by: Oumaima Hamza <[email protected]>
self.patient_id_raw defaults to None when not in use
* Dump to json output

* Process fusions and generate blob URLs from json template

* gzip instead of pysam

* skip header to use index

* debugging

* Fix column names

* debugging

* Fix genes combination scenario

* Get template json

* Specify path to file under plugin dir

* no message

* template json path

* debugging

* Reformat breakpoint

* Search for bam and bai files

* Use Node.js script for compression

* Get tumour ID

* Add positional argument

* Add compression script relative path

* Fix path

* Change to CommonJS syntax

* Add js scripts for compression

* Convert to to CommonJS syntax

* convert to CommonJS syntax

* Compression using pysam.bgzip

* base64 encoding

* Convert into URL safe base64

* Mimic the JavaScript behavior

* Fix blob URL format

* Fix base64 encode

* Compress json not the path to the file

* Change whizbam URL

* Change csv to tsv file

* Fix and refactor fusion test

* Changelog

* Respond to PR comments: Improve warning/error messages and replace hardcoded values with variables

* Clean up process_fusion function by adding helper functions

* Add custom error class

* Add whizbam_project parameter to the fusion plugin

* Optimizing checks for files existence and URL assignment

* Fix warning logging

---------

Co-authored-by: Oumaima Hamza <[email protected]>
* Update changelog and version.py

* Revert "Update changelog and version.py"

This reverts commit 97bf3d7.

* Update changelog and djerba version

* Revert "Update changelog and djerba version"

This reverts commit 26e27ac.

* Update changelog and djerba version

---------

Co-authored-by: Oumaima Hamza <[email protected]>
@AqsaAlam AqsaAlam changed the base branch from release-1.7.8 to release-1.7.9 January 6, 2025 16:44
Copy link
Collaborator

@iainrb iainrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're happy with my changes, I think we are good to merge this 😃

@AqsaAlam AqsaAlam merged commit f092d00 into release-1.7.9 Jan 22, 2025
1 check passed
@AqsaAlam AqsaAlam deleted the GCGI-1413_move-failed-report-plugin-to-summary branch January 22, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants