-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create components out of Aaron's work #6
Comments
2 tasks
Closing per this comment. |
Will create individual issues. |
corrideat
added a commit
that referenced
this issue
Jul 7, 2024
taoeffect
pushed a commit
that referenced
this issue
Jul 8, 2024
* Backport SW API changes without service worker * PR feedback * Feedback #2 * Feedback #3 * Feedback #4 * Feedback #5 * Feedback #6 (revert removing getters) * Feedback #7 * Feedback #8 * Queue login logout * Bugfix: wrong commit event * Fix voting by adding await * Documentation & bugfixes * Remove state/vuex/_private/save * Bugfixes * Add logoutInProgress check to prevent saving Chelonia state after a session ended * Add comment to DELETED_CHATROOM; remove Vue from contracts * Remove debug logging
taoeffect
pushed a commit
that referenced
this issue
Sep 5, 2024
* Fix #2277 - Fix reference count errors - Implement re-syncing contracts with foreign keys on `OP_KEY_SHARE` on foreign contract * Incorporate feedback * empty commit * Feedback, improvements & backwards-compatibility * Improved reference counting * Build #2 * Build #3 * Build #4 * Build #5 * Build #6 * Build #7 * Build #8 * Build #9 * Remove release * Build no. 2 * Build no. 3 * CI: Add test for unexpected tally * Build no. 2 * Add comment with example to referenceTally * Rectify referenceTally implementation errors * Add release on leaving group * Build no. 2 * Build no. 3 * Feedback * Update version message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue can be easily split up among multiple people.
First we should make a survey of all of the components to be extracted out of the HTML and into .vue files (i.e. make a list here), and then have at it!
EDIT: Many of these components are too simple to be worth creating
.vue
files out of. For those we just stick to the regular old markup and ignore (unless there's an obvious reason not to) the idea of making Vue components out of them. These I've marked, for now at least, "TOO SIMPLE — SKIP!"For now we will use
.vue
files primarily as pages. Only if it meaningfully improves the markup should we be spending our times creating components out of things that are already effectively components (like<button>
). It may even be worth considering avoiding the use of Vue.js and simply relaying on the Hapi backend to render template-based views directly (that would mean serving "normal" HTML files instead of this tiny skeleton). I've created issue #6 for this purpose.Here are the components I've isolated:
Note that as per
new-user.html
it can have a$
at the start and an optional image in the description!This is made up of the above components!
It should also be flexible enough to look like the box on
user-profile.html
!pay-group.html
The text was updated successfully, but these errors were encountered: