Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto prefixer config #401

Closed
wants to merge 2 commits into from
Closed

Auto prefixer config #401

wants to merge 2 commits into from

Conversation

alexnewmannn
Copy link
Contributor

Feature - Allow Users to provide a browser config for Autoprefix

  • Allow users to pass in a configuration string for auto prefixer (will add to wiki if accepted)
  • An input will be editable if AutoPrefix is enabled on Sass and Less from within the settings dialog, a user can edit comma separated values that are accepted by autoprefixer to use a custom configuration.
  • User error (i.e quotations) will be removed and stripped.
  • If no config is provided the default will be used.
  • Allow custom koala-config.json project files to be used and take precedence over GUI settings
  • Update default koala-config.json files for LESS and SASS for project templates
  • Minor tidy up with whitespace and missing semicolons
  • Add Ruby Gems to gitignore

@oklai I have a question involving the user config json and the priority - Should the users project settings json config take priority over the settings from the GUI? or the other way around? Currently this is set up so that if a project config file exists, that should be used over the settings in the GUI, can easily be swapped around but this looks to be the priority for all other settings (i.e ignores). Thanks!

@oklai
Copy link
Owner

oklai commented Apr 13, 2015

Hi @alexnewmannn
Great job, I have merge your pull request into the develop branch.
https://github.com/oklai/koala/commits/develop

@oklai oklai closed this Apr 13, 2015
@alexnewmannn
Copy link
Contributor Author

@oklai Nice, thanks - drop me a message on gitter or email if anything comes up or theres some missing functionality you want me to add!

@alexschwarz89
Copy link

"Minor tidy up with whitespace and missing semicolons" will fix the issue that combined JS files do not work because of missing semicolons? see http://stackoverflow.com/questions/10429838/uncaught-typeerror-undefined-is-not-a-function-on-loading-jquery-min-js

@alexnewmannn
Copy link
Contributor Author

@alexschwarz89 Probably not, this was just picking up errors from jshint and missing semicolons that were bothering me. Where do you see that issue with the missing semicolons?

@Colir
Copy link

Colir commented Oct 23, 2015

Hi. Can you please tell me how to configure autoprefixer ? I'm using Koala 2.0.4, and my autoprefix setting are not apply.
I use it like this in koala-config.json

"autoprefixConfig": "ff < 20"

but nothing change...
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants