Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: rename alias() to aliasWebpack() #60

Closed
oklas opened this issue Feb 22, 2022 · 1 comment
Closed

BREAKING CHANGE: rename alias() to aliasWebpack() #60

oklas opened this issue Feb 22, 2022 · 1 comment

Comments

@oklas
Copy link
Owner

oklas commented Feb 22, 2022

Rewire interface is typically uses two alias functions:

module.exports = alias(aliasMap)
module.exports.jest = aliasJest(aliasMap)

Switch to another name of library is a good time to increase readability of rewire API, and make more correct to understand, so:

- module.exports = alias(aliasMap)
+ module.exports = aliasWebpack(aliasMap)
  module.exports.jest = aliasJest(aliasMap)
oklas added a commit that referenced this issue Feb 22, 2022
@oklas
BREAKING CHANGE: function alias renamed to aliasWebpack #60
bee697b
oklas added a commit that referenced this issue Feb 22, 2022
@oklas
docs: replace function alias with aliasWebpack #60
1868665
@oklas oklas mentioned this issue Feb 25, 2022
Merged
oklas added a commit that referenced this issue Feb 25, 2022
@oklas
BREAKING CHANGE: function alias renamed to aliasWebpack #60
a44daa3
oklas added a commit that referenced this issue Feb 25, 2022
@oklas
docs: replace function alias with aliasWebpack #60
6db426d
oklas added a commit that referenced this issue Feb 25, 2022
@oklas
fix: function alias renamed to aliasWebpack #60
c9a6d38 
BREAKING CHANGE: The `alias` function has been renamed to `aliasWebpack` to improve the readability of the rewire API, as part of a major release along with a rename of the library itself.
oklas added a commit that referenced this issue Feb 25, 2022
@oklas
docs: replace function alias with aliasWebpack #60
d1ff6b3
@oklas
Copy link
Owner Author

oklas commented Feb 25, 2022

Closed in #61

@oklas oklas closed this as completed Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oklas