Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ua-parser-js. Change isMobileSafari18 to isSafari18 #1562

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Jan 14, 2025

  • Removed ua-parser-js
  • Rewritten isMobileSafari18 to isSafari18 without using external lib
  • Detecting both desktop and mobile Safari 18 because of comment and taking in account that enabling desktop mode in iOS Safari emulates Micantosh in user agent

@denysoblohin-okta denysoblohin-okta linked an issue Jan 14, 2025 that may be closed by this pull request
@jaredperreault-okta
Copy link
Contributor

Can you base this off 7.10?

@denysoblohin-okta denysoblohin-okta changed the base branch from master to 7.10 January 14, 2025 14:42
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 45e1ed3 into 7.10 Jan 14, 2025
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the remove-ua-parser-js branch January 14, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.10.0 includes breaking license change
2 participants