⬆️ Update dependencies #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haishengwu-okta
approved these changes
Oct 8, 2018
package.json
Outdated
| "lint:report": "eslint -f checkstyle -o build2/reports/lint/eslint-checkstyle-result.xml .", | ||
| "test": "grunt test", | ||
| "test": "npm run lint && npm run test:unit", |
There was a problem hiding this comment.
nit:
usually we didn't combine unit test and lint
There was a problem hiding this comment.
Good catch - we're already running this script in Travis and internally. I'll remove it.
jmelberg-okta
force-pushed
the
jm-update-deps
branch
from
d90a8e4 to
c6e98f2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates and removes outdated
devDependencies.